Rust contributors confirm widespread adoption of two-commit bug-fix pattern
3 Oct 31 1:06 PM · 11d ago · 1 post · 3 comments · 2 sources · development 3 of 4
Jana notes the technique is standard practice in Rust language contributions, where bug-fix pull requests split into two commits: one demonstrating the bug, one fixing it.
“I love this. It's one of the things I very often ask new contributors to rust-lang/rust to do when reviewing, and it's become kind of a standard. Any bug fix pr is two commits, and imo that's extremely important.”
janaJordi Gómez Hernández Developer and writerKurt Kluever Developer (originator of technique)
The whole story postscomments the bright band is this development · numbered dots are the others · click one to jump
What people said 3 voices · verbatim
-
I love this. It's one of the things I very often ask new contributors to rust-lang/rust to do when reviewing, and it's become kind of a standard. Any bug fix pr is two commits, and imo that's extremely important.
-
I'm familiar with this from contributing to LLVM.
-
I usually do this by adding a test for the fixed bug and a test that demonstrates the bug in action, but this is an interesting modification of the idea.
All 4 developments of The Kluever Maneuver: Writing Tests That Fail Before Fixing… →
LobstersHacker News